Skip to content

Fix #176: Remove unused ext-dom dependency#176

Merged
samdark merged 1 commit into
masterfrom
remove-ext-dom-requirement
Jun 10, 2026
Merged

Fix #176: Remove unused ext-dom dependency#176
samdark merged 1 commit into
masterfrom
remove-ext-dom-requirement

Conversation

@samdark

@samdark samdark commented Jun 10, 2026

Copy link
Copy Markdown
Member
Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Fixed issues
  • Remove the unused ext-dom runtime requirement.

Copilot AI review requested due to automatic review settings June 10, 2026 12:06
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.18%. Comparing base (73428a0) to head (4efdaad).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #176   +/-   ##
=========================================
  Coverage     87.18%   87.18%           
  Complexity      225      225           
=========================================
  Files            19       19           
  Lines           710      710           
=========================================
  Hits            619      619           
  Misses           91       91           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes an unused runtime dependency on the PHP ext-dom extension, updates documented requirements accordingly, and adds a regression test to prevent reintroducing the dependency.

Changes:

  • Remove ext-dom from composer.json runtime requirements.
  • Update README requirements to no longer list the DOM extension.
  • Add a PHPUnit regression test asserting ext-dom is not present in Composer runtime requirements.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
composer.json Drops ext-dom from runtime require.
README.md Updates the “Requirements” section to match Composer requirements.
tests/ComposerRequirementsTest.php Adds a test ensuring ext-dom is not reintroduced as a runtime requirement.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/ComposerRequirementsTest.php Outdated
Comment thread tests/ComposerRequirementsTest.php Outdated
@samdark samdark force-pushed the remove-ext-dom-requirement branch from 4efdaad to 66bfae1 Compare June 10, 2026 15:44
@samdark samdark force-pushed the remove-ext-dom-requirement branch from 66bfae1 to eeb97cd Compare June 10, 2026 15:46
@samdark samdark requested review from Copilot and vjik June 10, 2026 15:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment thread composer.json
@samdark samdark changed the title Remove unused DOM extension requirement Fix #176: Remove unused ext-dom dependency Jun 10, 2026
@samdark samdark merged commit fb9edbc into master Jun 10, 2026
23 of 24 checks passed
@samdark samdark deleted the remove-ext-dom-requirement branch June 10, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants