Add getBounds() method to range values#492
Draft
Tigrov wants to merge 5 commits into
Draft
Conversation
Tigrov
commented
Jun 15, 2026
Tigrov
commented
Member
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
| Fixed issues |
vjik
reviewed
Jun 15, 2026
vjik
left a comment
vjik
left a comment
Member
There was a problem hiding this comment.
Looks good.
Add new methods descriptions and psalm-types for results.
vjik
reviewed
Jun 16, 2026
| /** | ||
| * @template T | ||
| */ | ||
| interface RangeValueInterface extends ExpressionInterface |
Member
There was a problem hiding this comment.
Will this interface be used in the application? It seems we will always be working with a specific implementation.
Member
Author
There was a problem hiding this comment.
It is only required to limit return types of AbstractRangeColumn and AbstractMultiRangeColumn, currently using annotations, but in the next major release changing method signatures.
Also user-defined range types can realize it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.