Support more kindly for after method#1243
Conversation
0fa3b9d to
45c7a5c
Compare
|
I think we would be trying to do too much for the user here. There should be a contract since this is an API. Right now it says you need to return a Rack compatible response from I vote to close this without merging, lets leave it here for a bit see if others think strongly otherwise. |
|
Now, we must avoid returning value except false or nil on filters. I guess the constraint is very confusing. Thoughts? |
|
So if in I see what you mean though, but I think adding more "magic" to it isn't better. |
|
@dblock Yeah I see. I came to conclusion that your opinion is reasonable, but I'd like to hear other opinions. |
ref #1240
The current implementation is going to try to return
after_responseifafter_responseis not false.I guess the behavior is not expected, and users will be confusing.
Thoughts?