fix: Remove mistakenly added import#7848
Merged
Merged
Conversation
Contributor
|
Thanks for the PR @camdecoster |
emilykl
previously approved these changes
Jun 18, 2026
emilykl
previously approved these changes
Jun 18, 2026
emilykl
reviewed
Jun 18, 2026
Comment on lines
-562
to
-565
| it('can be set to other base urls', function(done) { | ||
| Plotly.newPlot(gd, [], {}, {plotlyServerURL: 'dummy'}) | ||
| .then(function() { | ||
| expect(gd._context.plotlyServerURL).toBe('dummy'); |
Contributor
There was a problem hiding this comment.
This test is perfectly fine to keep
emilykl
reviewed
Jun 18, 2026
Comment on lines
-567
to
-569
| Plotly.Plots.sendDataToCloud(gd); | ||
| expect(form.action).toContain('/dummy/external'); | ||
| expect(form.method).toBe('post'); |
Contributor
There was a problem hiding this comment.
These lines should be updated to an equivalent check that works for the new upload function
emilykl
reviewed
Jun 18, 2026
| }); | ||
| afterEach(destroyGraphDiv); | ||
|
|
||
| it('has lesser priotiy then window env', function(done) { |
Contributor
There was a problem hiding this comment.
Same for this test, we should keep it but update it
This reverts commit 74f178a.
emilykl
approved these changes
Jun 18, 2026
Contributor
Author
|
To close the loop, I dropped the test updates from this PR and Emily will manage those in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove mistakenly added import of
serverfromkarma.Closes #7847.
Testing
Make sure CI is passing.
Notes