Skip to content

feat: add format prop to TipTapEditor to support HTML content alongside markdown and include unit tests#5985

Merged
AlexVelezLl merged 1 commit into
learningequality:unstablefrom
Abhishek-Punhani:Issue5966
Jun 21, 2026
Merged

feat: add format prop to TipTapEditor to support HTML content alongside markdown and include unit tests#5985
AlexVelezLl merged 1 commit into
learningequality:unstablefrom
Abhishek-Punhani:Issue5966

Conversation

@Abhishek-Punhani

Copy link
Copy Markdown
Member

Summary

Added format prop to TipTapEditor to support HTML content alongside markdown and include unit tests

References

Fixes #5966

Reviewer guidance

AI usage

Used Antigravity for final review and nitpicks.

…n utilities

Signed-off-by: Abhishek-Punhani <punhani.manavabhi@gmail.com>
@learning-equality-bot

Copy link
Copy Markdown

👋 Hi @Abhishek-Punhani, thanks for contributing!

For the review process to begin, please verify that the following is satisfied:

  • Contribution is aligned with our contributing guidelines

  • Pull request description has correctly filled AI usage section & follows our AI guidance:

    AI guidance

    State explicitly whether you didn't use or used AI & how.

    If you used it, ensure that the PR is aligned with Using AI as well as our DEEP framework. DEEP asks you:

    • Disclose — Be open about when you've used AI for support.
    • Engage critically — Question what is generated. Review code for correctness and unnecessary complexity.
    • Edit — Review and refine AI output. Remove unnecessary code and verify it still works after your edits.
    • Process sharing — Explain how you used the AI so others can learn.

    Examples of good disclosures:

    "I used Claude Code to implement the component, prompting it to follow the pattern in ComponentX. I reviewed the generated code, removed unnecessary error handling, and verified the tests pass."

    "I brainstormed the approach with Gemini, then had it write failing tests for the feature. After reviewing the tests, I used Claude Code to generate the implementation. I refactored the output to reduce verbosity and ran the full test suite."

Also check that issue requirements are satisfied & you ran pre-commit locally.

Pull requests that don't follow the guidelines will be closed.

Reviewer assignment can take up to 2 weeks.

@AlexVelezLl AlexVelezLl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, and manual QA checks out! :)

@AlexVelezLl AlexVelezLl merged commit 28aeebb into learningequality:unstable Jun 21, 2026
20 checks passed
@AlexVelezLl AlexVelezLl self-assigned this Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[QTI/RTE] Add a format prop to the TipTap editor to support HTML input/output

2 participants