Java: convert all qlref tests to inline expectation tests using postprocessing#21966
Open
owen-mc wants to merge 5 commits into
Open
Java: convert all qlref tests to inline expectation tests using postprocessing#21966owen-mc wants to merge 5 commits into
owen-mc wants to merge 5 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mbaluda
reviewed
Jun 10, 2026
mbaluda
left a comment
mbaluda
left a comment
Contributor
There was a problem hiding this comment.
I'm not sure what your scope is, but there are a lot missing in the other java folders:
grep -rL "InlineExpectationsTestQuery" --include="*.qlref" java
Contributor
Author
|
Don't speak to me, speak to copilot 😆 . I'll look into it. I think the scope is any .qlref test referencing any query that has |
Contributor
Author
|
It was just looking in Java Inline Expectation Skip ListThis file lists the remaining AST dump queriesThese queries produce AST or extractor structure dumps rather than ordinary
Diagnostics and extractor telemetryThese queries validate extractor, database, or diagnostic output rather than source-level alerts.
Metrics, table, definitions, and tool-specific queriesThese queries are not ordinary inline-alert candidates because they produce summary, table, definitions, stub-generation, or tool endpoint output.
Special query kindThese tests do not use standard
Alert location is inside Javadoc or literal contentAdding inline comments would change the text or syntax being reported, making the converted test misleading or brittle.
Results are in shared stubs or vendored fixturesThese dead-code results are primarily reported in shared Apache Camel stub files, so inline comments would pollute shared fixtures.
|
owen-mc
force-pushed
the
java/convert-to-inline-expectation-tests
branch
from
37e782e to
a4bf2b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.