fix(body): fix data corruption during decompression (#108)#139
Open
cbonte wants to merge 1 commit into
Open
Conversation
cbonte
commented
Feb 5, 2026
cbonte
commented
- prevent mixed response containing plain text and gzipped data, due to c.Next() calls in DefaultDecompressHandle.
- prevent EOF while decompressing a buffered request body. This is easily triggered whith long payloads requiring several reads. The issue is that the defered close calls are performed on all the readers, including the top level one, and can close the request before the whole data is read. A workaround consists in not closing the top level reader.
* prevent mixed response containing plain text and gzipped data, due to c.Next() calls in DefaultDecompressHandle. * prevent EOF while decompressing a buffered request body. This is easily triggered whith long payloads requiring several reads. The issue is that the defered close calls are performed on all the readers, including the top level one, and can close the request before the whole data is read. A workaround consists in not closing the top level reader.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.