feat(appcheck): appcheck recaptcha enterprise support#18261
feat(appcheck): appcheck recaptcha enterprise support#18261cynthiajoan wants to merge 25 commits into
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for reCAPTCHA providers across Android, iOS, and Web platforms in firebase_app_check and integrates recaptchaSiteKey into FirebaseOptions across firebase_core platforms. Key feedback includes removing mavenLocal() from build files to prevent consumer dependency issues, adhering to the repository style guide by avoiding the ! operator in _safeToDart, and exporting WebProvider to replace dynamic types with safer, strongly-typed declarations in the example app.
| implementation platform("com.google.firebase:firebase-bom:${getRootProjectExtOrCoreProperty("FirebaseSDKVersion", firebaseCoreProject)}") | ||
| implementation 'com.google.firebase:firebase-appcheck-debug' | ||
| implementation 'com.google.firebase:firebase-appcheck-playintegrity' | ||
| compileOnly 'com.google.firebase:firebase-appcheck-recaptcha' |
There was a problem hiding this comment.
@rlazo would like to double check the compileOnly dependency with you. Since flutterfire AppCheck plugin is calling RecaptchaAppCheckProviderFactory, so we would have to include this for code compile, but the AAR would not be bundled to developer's app until they add the implementation of the firebase-appcheck-recaptcha. Does this sound correct to you?
There was a problem hiding this comment.
You can't have a compileOnly dependency on an AAR according to https://developer.android.com/build/dependencies#dependency_configurations
|
|
||
| if (provider is WebDebugProvider) { | ||
| if (provider == null || provider is WebReCaptchaProvider) { | ||
| jsProvider = null; |
There was a problem hiding this comment.
@cynthiajoan, mapping WebRecaptchaProvider to a null jsProvider initially seemed a bit odd to me, but I assume this is related to the changes introduced in firebase/firebase-js-sdk#10031. Just wanted to confirm if that’s the case.
|
@cynthiajoan Overall, LGTM. It may be worth addressing the analyzer and formatting CI issues |
4 participants
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?