chore(test): remove unused xunit dependencies#306
Merged
Conversation
Tests use a custom Fable.Python.Testing.FactAttribute that Fable lowers to a pytest test_ prefix; no test file references Xunit. The .NET test entry point was already a no-op returning 0. Drop xunit, xunit.runner.visualstudio, and Microsoft.NET.Test.Sdk to clear the deprecation warning and remove transitive bloat. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The native `dotnet run --project test/` path is a no-op (returns 0), so there is nothing else to test. Collapse the three-way test/test-native/ test-python split into a single `test` recipe that compiles the F# tests to Python and runs pytest. Update README and AGENTS docs accordingly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fable.Python.Testing.FactAttribute(defined atsrc/fable/Testing.fs:28) that Fable lowers to atest_prefix for pytest discovery. No test file referencesXunit.dotnet run --project test/entry point inMain.fsalready just returns0— .NET-side test discovery was a no-op regardless of which xunit version was installed.xunit,xunit.runner.visualstudio, andMicrosoft.NET.Test.Sdkfrompaket.dependencies/test/paket.references/paket.lock. The Test group now only resolvesFSharp.CoreandFable.Core.Test plan
dotnet build test/succeedsdotnet run --project test/exits 0 (unchanged behavior)just test-python— all 556 pytest tests pass