Skip to content

test(vue-query): replace deprecated 'toBeCalledWith' with 'toHaveBeenCalledWith'#10968

Merged
sukvvon merged 1 commit into
mainfrom
test/vue-query-usequery-replace-tobecalledwith
Jun 17, 2026
Merged

test(vue-query): replace deprecated 'toBeCalledWith' with 'toHaveBeenCalledWith'#10968
sukvvon merged 1 commit into
mainfrom
test/vue-query-usequery-replace-tobecalledwith

Conversation

@sukvvon

@sukvvon sukvvon commented Jun 17, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

🎯 Changes

toBeCalledWith is a deprecated Jest-style alias in Vitest. This replaces the remaining usage in vue-query's useQuery.test.ts with the canonical toHaveBeenCalledWith.

  • useQuery.test.ts: expect(useBaseQuery).toBeCalledWith(...) → toHaveBeenCalledWith(...)

Purely a matcher-name change; no assertion behavior is altered.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Tests
    • Updated test assertions for improved reliability and consistency in mock verification.

Note: This release contains internal test improvements with no user-facing changes.

@coderabbitai

coderabbitai Bot commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 03d7f166-4afe-4094-baa7-1bde33e67a48

📥 Commits

Reviewing files that changed from the base of the PR and between 835a299 and c9657f6.

📒 Files selected for processing (1)
  • packages/vue-query/src/__tests__/useQuery.test.ts
📝 Walkthrough

Walkthrough

A single test assertion in useQuery.test.ts is updated, replacing the toBeCalledWith matcher alias with toHaveBeenCalledWith when verifying that useBaseQuery is called with QueryObserver and the expected query options.

Changes

useQuery Test Assertion Update

Layer / File(s) Summary
Replace deprecated matcher alias
packages/vue-query/src/__tests__/useQuery.test.ts		 Switches toBeCalledWith to toHaveBeenCalledWith on the assertion that verifies useBaseQuery is called with QueryObserver and query options.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Possibly related PRs

  • TanStack/query#10935: Same matcher migration (toBeCalledWith → toHaveBeenCalledWith) applied to other vue-query test files.
  • TanStack/query#10937: Parallel migration of toBeCalledTimes → toHaveBeenCalledTimes in useQuery-related tests.
  • TanStack/query#10938: Same pattern of replacing deprecated toBeCalled* aliases with toHaveBeenCalled* counterparts in Vitest tests.

Poem

🐇 A tiny hop, a small swap made,
toBeCalledWith gently laid to rest,
toHaveBeenCalledWith now takes the stage,
No alias shall pass my burrow's test!
The query hops on, properly blessed. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the primary change: replacing a deprecated Jest matcher with its canonical Vitest equivalent in the vue-query test file.
Description check ✅ Passed The description follows the required template structure with complete sections covering changes, checklist items, and release impact, clearly explaining the matcher replacement with no assertion behavior changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/vue-query-usequery-replace-tobecalledwith

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud

nx-cloud Bot commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit c9657f6

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 3m 10s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 17s View ↗

☁️ Nx Cloud last updated this comment at 2026-06-17 10:48:01 UTC

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@sukvvon sukvvon self-assigned this Jun 17, 2026
@pkg-pr-new

pkg-pr-new Bot commented Jun 17, 2026

Copy link
Copy Markdown
More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10968

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10968

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@10968

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10968

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10968

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10968

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10968

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10968

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10968

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10968

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10968

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10968

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10968

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10968

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10968

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10968

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10968

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10968

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10968

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10968

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10968

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10968

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10968

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10968

commit: c9657f6

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
react full 12.11 KB (0%)
react minimal 9.08 KB (0%)

@sukvvon sukvvon merged commit a7b783a into main Jun 17, 2026
9 checks passed
@sukvvon sukvvon deleted the test/vue-query-usequery-replace-tobecalledwith branch June 17, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sukvvon sukvvon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sukvvon