Added sidecar mechanism for hard-fault-/thread-kill-tolerant CI test logging#641
Open
Micky774 wants to merge 1 commit into
Open
Added sidecar mechanism for hard-fault-/thread-kill-tolerant CI test logging#641Micky774 wants to merge 1 commit into
Micky774 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The CI test summary (
junit_report.py) is a pure aggregator of JUnit XML files, but pytest writes its--junitxmlonly at session end so a--timeout-method=threadfiring, segfault, or OOM-kill thatos._exit()s the process produces no XML for that file, and the summary silently drops it and shows green even though the suite exit-code gate correctly fails.This change closes that gap on two levels:
(1) a new
te_ci_result_sinkpytest plugin streams each test's progress to a<junitxml>.partialsidecar (flushed per line, deleted on clean exit), whichjunit_report.pyreconstructs when a run hard-exits, preserving pre-crash passes and surfacing the in-flight test as a[timeout](2) as a floor,
pytest_runnow synthesizes a minimal error report when pytest exits non-zero without writing any XML at all (e.g. usage/conftest-import errors before the plugin loads), so the summary always stays consistent with the pass/fail gate. Verified end-to-end against real thread-method timeouts, conftest errors, normal failures, and clean passes.Type of change
Changes
Please list the changes introduced in this PR:
Checklist: