feature: add public brokerage integration#651
Open
Romazes wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the Public.com brokerage to the CLI command reference (
README.md). The change is thescripts/readme.pyoutput regenerated from the updatedmodules-1.14.json:Publicis added to the--brokerageand--data-provider-historicalchoice lists, and the--public-secret-key/--public-account-numberoptions are documented forlean liveandlean cloud live deploy.Related PR(s)
Related Issue
N/A
Motivation and Context
The Public.com brokerage plugin is implemented and needs to be selectable from the CLI. This mirrors the Webull integration (#645), which added the brokerage to the same command reference.
Requires Documentation Change
This is the documentation change. The
modules-1.14.jsonfile is maintained separately (it is gitignored in this repo and shared with the team for review), so it is not part of this PR.How Has This Been Tested?
python scripts/readme.py; the diff is limited toREADME.md.Publicappears in--brokerageand--data-provider-historical.Publicis absent from--data-provider-live: Public.com has no real-time market-data stream, so the brokerage advertises nodata-queue-handlercapability (Subscribe/UnsubscribethrowNotSupportedException).PublicBrokerageFactory.BrokerageData:public-secret-key,public-account-number.Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>