[18.0][FIX] document_page: fix type error, tuple assignment

[jans23]

How to reproduce: Knowledge -> Pages -> Change Requests -> New this causes the following exception:

Traceback (most recent call last):
  File "/srv/odoo/odoo/parts/odoo/odoo/http.py", line 2167, in _transactioning
    return service_model.retrying(func, env=self.env)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/odoo/odoo/parts/odoo/odoo/service/model.py", line 157, in retrying
    result = func()
             ^^^^^^
  File "/srv/odoo/odoo/parts/odoo/odoo/http.py", line 2134, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/odoo/odoo/parts/odoo/odoo/http.py", line 2382, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/odoo/odoo/parts/odoo/odoo/addons/base/models/ir_http.py", line 333, in _dispatch
    result = endpoint(**request.params)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/odoo/odoo/parts/odoo/odoo/http.py", line 754, in route_wrapper
    result = endpoint(self, *args, **params_ok)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/addons/web/controllers/dataset.py", line 36, in call_kw
    return call_kw(request.env[model], method, args, kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/odoo/odoo/parts/odoo/odoo/api.py", line 535, in call_kw
    result = getattr(recs, name)(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/addons/web/models/models.py", line 1019, in onchange
    snapshot1 = RecordSnapshot(record, fields_spec)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/addons/web/models/models.py", line 1106, in __init__
    self.fetch(name)
  File "/tmp/addons/web/models/models.py", line 1121, in fetch
    self[field_name] = self.record[field_name]
                       ~~~~~~~~~~~^^^^^^^^^^^^
  File "/srv/odoo/odoo/parts/odoo/odoo/models.py", line 7083, in __getitem__
    return self._fields[key].__get__(self)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/odoo/odoo/parts/odoo/odoo/fields.py", line 1311, in __get__
    self.compute_value(recs)
  File "/srv/odoo/odoo/parts/odoo/odoo/fields.py", line 1493, in compute_value
    records._compute_field_value(self)
  File "/tmp/addons/mail/models/mail_thread.py", line 443, in _compute_field_value
    return super()._compute_field_value(field)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/odoo/odoo/parts/odoo/odoo/models.py", line 5302, in _compute_field_value
    fields.determine(field.compute, self)
  File "/srv/odoo/odoo/parts/odoo/odoo/fields.py", line 110, in determine
    return needle(*args)
           ^^^^^^^^^^^^^
  File "/tmp/addons/document_page/models/document_page_history.py", line 57, in _compute_display_name
    rec.display_name = rec.id, "%s #%i" % (rec.page_id.name, rec.id)
                               ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
TypeError: %i format: a real number is required, not NewId

[KDRdev]

Tested. LGTM

[jans23]

@etobella could you review this, please?

[Reyes4711-S73]

LGTM

[adrip-s73]

LGTM

[etobella]

LGTM

However, can you use a proper commit name.

Something like [IMP] document_page: Fix tuple assignment error

[BhaveshHeliconia]

@jans23 could you please take a look at this suggestion?

#605 (review)

Other than that, LGTM!

[jans23]

@BhaveshHeliconia I changed the commit name accordingly. Anything else?

[BhaveshHeliconia]

@BhaveshHeliconia I changed the commit name accordingly. Anything else?

Also, could you please update the PR title to something more appropriate?

[jans23]

Done. Like this?

[etobella]

/ocabot merge patch

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-605-by-etobella-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at c5313cf. Thanks a lot for contributing to OCA. ❤️