Proxy add watchdog

[hhaAndroid]

• 之前 proxy 判断逻辑非常 hard code，这版本移除，而是要用户显式设置
• 之前 proxy 没有支持注册和移除功能，在 worker 失败和重启中无法联动，目前已经支持

[hhaAndroid]

@claude review

[claude]

Claude: ## Summary

Moves proxy management from the trainer into the rollout subsystem via a new RolloutProxyManager that hooks into worker lifecycle events. Replaces hard-coded class-name checks with a declarative requires_rollout_proxy field on AgentLoopConfig. Good architectural improvement — decouples proxy logic from the trainer and enables automatic proxy sync on worker failure/recovery.

ProduceBatchResult impact: not affected
RoutedExperts impact: not affected

Issues

Critical

• xtuner/v1/train/rl_trainer.py:654-657 _ensure_rollout_proxy_config has no self.logger.info() call, but the test asserts trainer.logger.info.assert_called_once(). Test will fail.

Warning

• xtuner/v1/rl/rollout/proxy_manager.py:18-20 No thread synchronization on _registered_session_urls. Concurrent lifecycle notifications from health-check and recovery threads could race on the check-then-act patterns in _register_session_url/_delete_session_url.

Nit

• xtuner/v1/rl/rollout/proxy_manager.py:25-28 Partial failure in replace_registered_session_urls loop leaves proxy in inconsistent state (some URLs registered, some not). Consider best-effort continuation or full rollback.
• xtuner/v1/rl/rollout/proxy_manager.py:15-16 Docstring word-wrap looks like a formatter artifact splitting mid-phrase.

Verdict

REQUEST_CHANGES — the test/implementation mismatch needs a fix before merge.

[hhaAndroid]

@claude review

[claude]

Claude: ## Summary

Re-reviewed after new commits. The previous critical issue (test asserting logger.info that didn't exist) has been fixed. Thread safety concern addressed by moving lifecycle notifications inside _operation_lock.

Good architectural improvement: replaces hard-coded class-name proxy checks with a declarative requires_rollout_proxy field, moves proxy lifecycle management into RolloutProxyManager that hooks into the health manager via a clean RolloutWorkerLifecycleListener protocol, and adds proper validation via validate_registered_workers_to_proxy before training starts.

ProduceBatchResult impact: not affected
RoutedExperts impact: not affected

Issues

Nit

• proxy_manager.py:38-42 Only the last registration result is captured in register_result; intermediate results are lost for debugging.
• worker.py:424-437 Hardcoded internal URLs as defaults for routed_proxy_url/routed_proxy_admin_url could confuse external users if proxy is enabled without overriding them.

Verdict

APPROVE — previous concerns resolved, architecture is clean, tests cover the key behaviors.

[YanhuiDua]

这里为什么要被锁保护呢 ？

[hhaAndroid]

claude code 说有可能存在偶发的竞态。放到里面最保险