Wateruse#905
Open
ldecicco-USGS wants to merge 11 commits into
Open
Conversation
Merge branch 'develop' of github.com:ldecicco-USGS/dataRetrieval into wateruse # Conflicts: # R/readNWISunit.R # tests/testthat/tests_userFriendly_fxns.R # vignettes/Status.Rmd # vignettes/dataRetrieval.Rmd
Merge branch 'develop' of github.com:DOI-USGS/dataRetrieval into wateruse # Conflicts: # R/walk_pages.R # vignettes/Status.Rmd # vignettes/dataRetrieval.Rmd
Merge branch 'develop' of github.com:DOI-USGS/dataRetrieval into wateruse # Conflicts: # R/readNWISunit.R # R/walk_pages.R # vignettes/Status.Rmd # vignettes/dataRetrieval.Rmd # vignettes/tutorial.Rmd
cnell-usgs
reviewed
Jun 23, 2026
| #' @param model See model IDs on the NWDC data catalog page. | ||
| #' Options are : "wu-public-supply-wd", "wu-thermoelectric", "wu-irrigation-cu", | ||
| #' "wu-irrigation-wd", and "wu-public-supply-cu" | ||
| #' @param variable See variable IDs on the NWDC data catalog page. |
Member
There was a problem hiding this comment.
| % Please edit documentation in R/read_waterdata_use.R | ||
| \name{read_waterdata_use_data} | ||
| \alias{read_waterdata_use_data} | ||
| \title{Get USGS Daily Data} |
Member
There was a problem hiding this comment.
should be water use, not daily
| #' startdate = "2020", | ||
| #' timeres = "annualwy") | ||
| #' } | ||
| read_waterdata_use_data <- function(model = NA_character_, |
Member
There was a problem hiding this comment.
may want to revisit naming. read_waterdata_usedata would be a more consistent pattern with 'data'
|
|
||
|
|
||
|
|
||
| Coming soon, a new new access point for the National Groundwater Monitoring Network. The original `readNGWMNdata` functions have been broken for some time. `read_waterdata_use` is currently in development! |
Member
There was a problem hiding this comment.
fxn name is different here. I like this one best
| limit = 600){ | ||
|
|
||
| args <- mget(names(formals())) | ||
| args <- Filter(Negate(anyNA), args) |
Member
There was a problem hiding this comment.
include some kind of validation of the input
| #' @param startdate Format : YYYY (for annual data) or YYYY-MM (for monthly data) | ||
| #' @param enddate Format : YYYY (for annual data) or YYYY-MM (for monthly data) | ||
| #' @param intersection Options : overlap, envelop | ||
| #' @param limit Defines the number of HUC12s returned per page or file. |
Member
There was a problem hiding this comment.
testing this it seems like over 10000 maxes out the server and returns 400 error
Merge branch 'develop' of github.com:DOI-USGS/dataRetrieval into wateruse # Conflicts: # R/walk_pages.R
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial push of water use function.