Skip to content

build(cudf): Add cudf label to cudf pull request#16976

Closed
jinchengchenghh wants to merge 10 commits into
facebookincubator:mainfrom
jinchengchenghh:cudf_label
Closed

build(cudf): Add cudf label to cudf pull request#16976
jinchengchenghh wants to merge 10 commits into
facebookincubator:mainfrom
jinchengchenghh:cudf_label

Conversation

@jinchengchenghh

@jinchengchenghh jinchengchenghh commented Mar 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Add the cudf label by actions/labeler@v5, may also add labels like iceberg, aggregate, functions in the future.

@netlify

netlify Bot commented Mar 31, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit ba85954
🔍 Latest deploy log https://app.netlify.com/projects/meta-velox/deploys/6a233fc7e2b3420008b3f3f8

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 31, 2026
@github-actions

github-actions Bot commented Mar 31, 2026 •
edited
Loading

Copy link
Copy Markdown

Build Impact Analysis

No build targets affected by this change.

Fast path • Graph from main@c441ece28d1a34399cc65ac022b27d2c7f256ab1

@jinchengchenghh jinchengchenghh marked this pull request as draft March 31, 2026 12:34
@jinchengchenghh jinchengchenghh changed the title feat(cudf): Add cudf label to cudf pull request feat(cudf): Add cudf label to cudf pull request Mar 31, 2026
@jinchengchenghh jinchengchenghh changed the title feat(cudf): Add cudf label to cudf pull request feat(cudf): Add cudf label to cudf pull request Mar 31, 2026
@jinchengchenghh jinchengchenghh changed the title feat(cudf): Add cudf label to cudf pull request feat(cudf): Add cudf label to cudf pull request Mar 31, 2026
@jinchengchenghh jinchengchenghh changed the title feat(cudf): Add cudf label to cudf pull request feat(cudf): Add cudf label to cudf pull request Mar 31, 2026
@devavret

devavret commented Mar 31, 2026

Copy link
Copy Markdown
Collaborator

Thanks for this. It's been on our mind to do this for a while. But unfortunately I cannot review since I'm not experienced with github workflows.

jinchengchenghh
jinchengchenghh commented Mar 31, 2026
View reviewed changes
Comment thread .github/workflows/label-cudf.yml Outdated
jinchengchenghh
jinchengchenghh commented Mar 31, 2026
View reviewed changes
Comment thread .github/workflows/labeler.yml
name: Labeler

on:
pull_request_target:

@jinchengchenghh jinchengchenghh Mar 31, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With pull_request_target, GitHub always runs the workflow from the base branch (e.g., main), not from your PR branch.

@jinchengchenghh jinchengchenghh marked this pull request as ready for review March 31, 2026 13:02
@jinchengchenghh

jinchengchenghh commented Mar 31, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks for your reply, please make sure the feature worked as you expect, I will ask Meta to verify the semantics. @devavret

@jinchengchenghh

jinchengchenghh commented Mar 31, 2026

Copy link
Copy Markdown
Collaborator Author

The label feature worked as Gluten labels.

@jinchengchenghh

jinchengchenghh commented Apr 1, 2026

Copy link
Copy Markdown
Collaborator Author

Hi, @kgpai , this feature is cudf team want to do, it must take effect after it merged to main since it runs on pull_request_target to access the secret token, could you help merge it? And then we can verify if it worked as we expected.

@jinchengchenghh

jinchengchenghh commented Apr 6, 2026

Copy link
Copy Markdown
Collaborator Author

Hi @majetideepak @czentgr What do you think about that?

@jinchengchenghh jinchengchenghh changed the title feat(cudf): Add cudf label to cudf pull request ci(cudf): Add cudf label to cudf pull request Apr 6, 2026
@jinchengchenghh jinchengchenghh changed the title ci(cudf): Add cudf label to cudf pull request build(cudf): Add cudf label to cudf pull request Apr 6, 2026
@karthikeyann karthikeyann requested a review from bdice April 6, 2026 15:06
@karthikeyann

karthikeyann commented Apr 6, 2026

Copy link
Copy Markdown
Collaborator

Added @bdice to review the Github workflow.

karthikeyann
karthikeyann reviewed Apr 6, 2026
View reviewed changes

@karthikeyann karthikeyann left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would defer the approval to Github workflow experts.
Looks good to me. 1 minor question.

Comment thread .github/workflows/labeler.yml Outdated
bdice
bdice reviewed Apr 6, 2026
View reviewed changes
Comment thread .github/zizmor.yml Outdated
Comment thread .github/labeler.yml
# See the License for the specific language governing permissions and
# limitations under the License.
# Automatically add labels based on file paths
cudf:

@bdice bdice Apr 6, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there other component labels we should consider adding? (e.g. pyvelox, etc.) It seems like enabling this workflow should be a decision for the Velox core maintainers, I don't want to add this just for cudf unless the core maintainers are aligned that this is desirable.

@jinchengchenghh jinchengchenghh Apr 7, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This framework now adds cudf labels, let us wait for the Velox core maintainers, they can also add labels like wave, aggregates, iceberg with this framework, there are many labels but they are not used now.

@karthikeyann karthikeyann Apr 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @kgpai @czentgr @assignUser

@kgpai

kgpai commented May 11, 2026

Copy link
Copy Markdown
Contributor

Hi @jinchengchenghh , Is the reason for this purely for UI and filtering purposes ? Or could these labels be used in other capacities in the future ?

@jinchengchenghh

jinchengchenghh commented May 12, 2026

Copy link
Copy Markdown
Collaborator Author

First, this is for filtering.
Second, we can fetch the pull requests with cudf label and do some pretests and verify them. Because cudf code is under actively developing and review, it may take some time to wait for ready to merge, but we could have a preview branch to have more features, and help us track the cudf pull requests status. @kgpai

@karthikeyann

karthikeyann commented May 22, 2026

Copy link
Copy Markdown
Collaborator

could these labels be used in other capacities in the future ?

Yes. The label "cudf" is used for creating the staging branch. So, if tests in staging branch is broken, PR owner takes special care to not break integration, helps us catch issues early, prevents breaking CI too.

@karthikeyann karthikeyann requested a review from bdice May 22, 2026 17:33
karthikeyann
karthikeyann approved these changes Jun 5, 2026
View reviewed changes

@karthikeyann karthikeyann left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@karthikeyann

karthikeyann commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Requesting @kgpai for review.

@kgpai kgpai added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Jun 11, 2026
@meta-codesync

meta-codesync Bot commented Jun 12, 2026

Copy link
Copy Markdown

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this in D108380795.

@meta-codesync meta-codesync Bot closed this in 97d0892 Jun 12, 2026
@meta-codesync meta-codesync Bot added the Merged label Jun 12, 2026
@meta-codesync

meta-codesync Bot commented Jun 12, 2026

Copy link
Copy Markdown

@xiaoxmeng merged this pull request in 97d0892.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgpai kgpai kgpai approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

@majetideepak majetideepak Awaiting requested review from majetideepak majetideepak is a code owner

@devavret devavret Awaiting requested review from devavret

@czentgr czentgr Awaiting requested review from czentgr

@bdice bdice Awaiting requested review from bdice

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jinchengchenghh @devavret @karthikeyann @kgpai @bdice